Fix a bunch of issues with logging. #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I ran into these issues while trying to understand why my job was marked as failed even though there was no useful informatin about why the pod failed. * Log events that indicate exit code of pods. * In the json payload use the syntax namespace + "." + name not namespace + "/" + name; use of a period is more consistent in K8s * Don't log an event TFJob is terminated, deleting pods and services; this event ends up being triggered repeatedly because of CleanPodPolicy the number of completed pods is non zero so the event statement kept getting called; the event is unnecessary because we will create events corresponding to actual services/events deleted.
|
/assign @gaocegege |
|
/lgtm |
Travis tests have failedHey @jlewi, 2nd Buildgometalinter --config=linter_config.json --vendor ./...3rd Buildgometalinter --config=linter_config.json --vendor ./... |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into these issues while trying to understand why my job was
marked as failed even though there was no useful informatin about
why the pod failed.
Log events that indicate exit code of pods.
In the json payload use the syntax namespace + "." + name not
namespace + "/" + name; use of a period is more consistent in K8s
Don't log an event TFJob is terminated, deleting pods and services;
this event ends up being triggered repeatedly because of CleanPodPolicy
the number of completed pods is non zero so the event statement kept
getting called; the event is unnecessary because we will create
events corresponding to actual services/events deleted.
This change is