Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: Remove dup code and use k8s.io/kubernetes/controller #594

Merged
merged 6 commits into from
May 20, 2018
Merged

controller: Remove dup code and use k8s.io/kubernetes/controller #594

merged 6 commits into from
May 20, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 11, 2018

Close #591

/assign @ScorpioCPH


This change is Reviewable

@gaocegege
Copy link
Member Author

We could just review 4804a2a

@TravisBuddy

This comment has been minimized.

@gaocegege
Copy link
Member Author

I forgot to update the test 😟 Will do it later (After 5.15)

gaocegege added 4 commits May 17, 2018 18:21
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@TravisBuddy
Copy link

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...
pkg/controller.v2/controller_test.go:51::warning: line is 251 characters (lll)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
pkg/controller.v2/controller_test.go:51::warning: line is 251 characters (lll)

travis_time:end:0077a0b0:start=1526554100377033105,finish=1526554182912609806,duration=82535576701

@coveralls
Copy link

coveralls commented May 17, 2018

Coverage Status

Coverage increased (+6.4%) to 55.646% when pulling c5712ba on gaocegege:kubernetes into e984dd2 on kubeflow:master.

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@TravisBuddy

This comment has been minimized.

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/assign @ScorpioCPH

PTAL

@jimexist
Copy link
Member

LGTM

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gaocegege gaocegege added the lgtm label May 20, 2018
@gaocegege
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9be6c5d into kubeflow:master May 20, 2018
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
…eflow#594)

* dep: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* vendor: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* *: Use k8s.io/kubernetes/controller

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
…eflow#594)

* dep: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* vendor: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* *: Use k8s.io/kubernetes/controller

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants