-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller: Remove dup code and use k8s.io/kubernetes/controller #594
Conversation
We could just review 4804a2a |
This comment has been minimized.
This comment has been minimized.
I forgot to update the test 😟 Will do it later (After 5.15) |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Travis tests have failedHey @gaocegege, 2nd Buildgometalinter --config=linter_config.json --vendor ./...
3rd Buildgometalinter --config=linter_config.json --vendor ./...
|
This comment has been minimized.
This comment has been minimized.
/assign @ScorpioCPH PTAL |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…eflow#594) * dep: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * vendor: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * *: Use k8s.io/kubernetes/controller Signed-off-by: Ce Gao <gaoce@caicloud.io> * test: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * test: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * test: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io>
…eflow#594) * dep: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * vendor: Update Signed-off-by: Ce Gao <gaoce@caicloud.io> * *: Use k8s.io/kubernetes/controller Signed-off-by: Ce Gao <gaoce@caicloud.io> * test: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * test: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io> * test: Fix Signed-off-by: Ce Gao <gaoce@caicloud.io>
Close #591
/assign @ScorpioCPH
This change is