Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run glide update to update glide.lock #410

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Run glide update to update glide.lock #410

merged 1 commit into from
Feb 26, 2018

Conversation

ankushagarwal
Copy link

@ankushagarwal ankushagarwal commented Feb 26, 2018 •
edited by jlewi
Loading

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Feb 26, 2018

nit: Can you explain why we need to pull in new dependencies? i.e. what is the change that precipatated pulling in new dependencies?

@ankushagarwal ankushagarwal requested a review from wackxu February 26, 2018 21:27
@ankushagarwal
Copy link
Author

I'm planning to add a new dependency - github.com/onrik/logrus/filename. To add that I need to run glide update, which updates all the dependencies in this repository. So I want to check changes unrelated to github.com/onrik/logrus/filename in a separate PR.

@jlewi jlewi merged commit ab1cb4d into kubeflow:master Feb 26, 2018
@ankushagarwal ankushagarwal deleted the glide branch February 27, 2018 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

@wackxu wackxu Awaiting requested review from wackxu

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankushagarwal @jlewi @k8s-ci-robot