Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes go vet errors #397

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Fixes go vet errors #397

merged 1 commit into from
Feb 22, 2018

Conversation

swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Feb 22, 2018 •
edited
Loading

Addressing #395.

There are some errors in our code but it won't caught by the compilers

$ go vet $(go list ./... | grep -v /vendor/)

Output:

cmd/tf-operator/app/server.go:129: unreachable code
exit status 1
dashboard/backend/handler/api_handler.go:36: struct field tfJobs has json tag but is not exported
dashboard/backend/handler/api_handler.go:41: struct field namespaces has json tag but is not exported
exit status 1

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Feb 22, 2018

/ok-to-test
This should be good to merge as soon as the tests pass.

@swiftdiaries Would be good if you could sync.

@coveralls
Copy link

coveralls commented Feb 22, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 868

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 31.856%
Totals Coverage Status
Change from base Build 861: 0.1%
Covered Lines: 582
Relevant Lines: 1827
💛 - Coveralls

@jlewi jlewi merged commit 87c4bba into kubeflow:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swiftdiaries @jlewi @coveralls @k8s-ci-robot