Generate a single swagger.json file for all frameworks
#1437
Conversation
|
/cc @andreyvelich |
There was a problem hiding this comment.
Thank you so much for this update @alembiewski!
Small question from me.
| "${repo_root}"/pkg/apis/mxnet/v1/swagger.json "${repo_root}"/pkg/apis/xgboost/v1/swagger.json \ | ||
| --output "${repo_root}"/hack/python-sdk/swagger.json --quiet || true | ||
| echo "Generating swagger file ..." | ||
| go run "${repo_root}"/hack/python-sdk/main.go ${VERSION} > "${SWAGGER_CODEGEN_FILE}" |
There was a problem hiding this comment.
You re-run this script to generate the new Swagger, right ?
There was a problem hiding this comment.
Yes, that's correct. It has produced the file with the same contents as before, except now it has a proper title and description, so, effectively, no changes. And I also regenerated the SDK using the updated spec
|
Thank you for the update! |
|
/assign @Jeffwan /lgtm |
|
The changes looks stratforward. Let's hold this PR until the presubmit job is re-enabled. kubeflow/testing#967 |
|
/hold |
|
/retest all |
|
@Jeffwan: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test kubeflow-training-operator-presubmit |
|
@alembiewski since we rename the repo, there's a corresponding change in ci #1440. Please help rebase master change and it will make test behave correctlt. |
Pull Request Test Coverage Report for Build 1322322934
💛 - Coveralls |
|
/test kubeflow-training-operator-presubmit |
|
@alembiewski: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Jeffwan, I updated the PR with the latest changes - could you please trigger the test again? |
|
Thank you @alembiewski! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alembiewski, Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alembiewski, Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Update the tooling used for swagger spec generation to create a single
swagger.jsonfile for all API types instead of generating separate files for each API and combine them withswagger mixinutility.Python SDK has been regenerated to update the package metadata in dockstrings.