Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix calling custom_api.delete_namespaced_custom_object args error #1281

Merged
merged 1 commit into from
Jun 4, 2021
Merged

fix calling custom_api.delete_namespaced_custom_object args error #1281

merged 1 commit into from
Jun 4, 2021

Conversation

Windfarer
Copy link
Contributor

fix #1275
This issue is mainly caused by the API upgrade in kubernetes-client/python#1141

Related code is here https://github.com/kubernetes-client/python/blob/c206745dcd491d64b63260c6b6f46e3a3a81b101/kubernetes/client/api/custom_objects_api.py#L559

image
This commit drops the args name and body, then recover the name args in the following commits.

Now this API's body argument is handled by kwargs.

If user install kubernetes python client's version >= v11.0.0 will run into this error.
The temporary solution is to downgrade kubernetes client to v10.1.0

And a possible fixing is to use keyword arguments instead of positional arguments.

@aws-kf-ci-bot
Copy link
Contributor

Hi @Windfarer. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.429% when pulling 897109c on Windfarer:fix_tfjob_delete into c095f7a on kubeflow:master.

@johnugeorge johnugeorge mentioned this pull request Jun 3, 2021
Closed
gaocegege
gaocegege approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@gaocegege
Copy link
Member

/ok-to-test

@aws-kf-ci-bot
Copy link
Contributor

@Windfarer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 897109c link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

terrytangyuan
terrytangyuan approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege
Copy link
Member

/approve

@gaocegege gaocegege merged commit 6fd9489 into kubeflow:master Jun 4, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eundonglee eundonglee mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@terrytangyuan terrytangyuan

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the delete in python SDK is not working
6 participants
@Windfarer @aws-kf-ci-bot @coveralls @gaocegege @google-oss-robot @terrytangyuan