Add task type annotation for pods when EnableGangScheduling is true. #1268
Conversation
Signed-off-by: jiangkaihua <jiangkaihua1@huawei.com>
|
Hi @jiangkaihua. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @shinytang6 |
|
@gaocegege: GitHub didn't allow me to assign the following users: shinytang6. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@william-wang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@shinytang6: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm /approve Thanks for your contribution! 🎉 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, jiangkaihua, shinytang6, william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
| @@ -55,6 +55,8 @@ const ( | |||
| labelGroupName = "group-name" | |||
| // Deprecated label for backwards compatibility. Has to be removed | |||
| labelTFJobName = "tf-job-name" | |||
| // volcanoTaskSpecKey task spec key used in pod annotation when EnableGangScheduling is true | |||
| volcanoTaskSpecKey = "volcano.sh/task-spec" | |||
There was a problem hiding this comment.
@jiangkaihua I suggest this is better to add the annotation like scheduling.k8s.io/task-spec=ps to announce task type.
This will be consistent with scheduling.k8s.io/group-name. This will make the naming more general and convenient for users. task-spec:ps/trainer is the proper name of distributed training. A general name is more reasonable other than volcano task spec.
/cc @gaocegege
There was a problem hiding this comment.
Should we discuss it with volcano members?
There was a problem hiding this comment.
Yes, l think it makes sense, but it needs some modification to volcano.
/cc @jiangkaihua
There was a problem hiding this comment.
Is there any other project may use this annotation?
There was a problem hiding this comment.
Yes, Our project will also need to know the task-spec of the pod. More important is that task-spec is the proper name of distributed training. A general name is more reasonable.
|
@shinytang6: GitHub didn't allow me to request PR reviews from the following users: jiangkaihua. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: jiangkaihua jiangkaihua1@huawei.com