Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tfjob dashboard #1119

Merged
merged 2 commits into from
Dec 24, 2019
Merged

remove tfjob dashboard #1119

merged 2 commits into from
Dec 24, 2019

Conversation

ChanYiLin
Copy link
Member

@ChanYiLin ChanYiLin commented Dec 24, 2019 •
edited
Loading

This PR remove the dashboard since it is no longer maintained and used.

fix #1113

This change is Reviewable

@ChanYiLin
Copy link
Member Author

/assign @gaocegege
Here is the PR to remove it.
I want to check whether this breaks the ci pipeline, so lets merge it after making sure ci still works

@coveralls
Copy link

coveralls commented Dec 24, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 96.512% when pulling 3a1eb7a on ChanYiLin:master into b04beff on kubeflow:master.

@TravisBuddy
Copy link

Hey @ChanYiLin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 4731bae0-25f8-11ea-8748-5b98fb6aa2de

gaocegege
gaocegege reviewed Dec 24, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 24, 2019
@TravisBuddy
Copy link

Hey @ChanYiLin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e6a921b0-2604-11ea-8748-5b98fb6aa2de

@ChanYiLin
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link

@ChanYiLin: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChanYiLin
Copy link
Member Author

ChanYiLin commented Dec 24, 2019 •
edited
Loading

@gaocegege I fixed the CI problem and it passes the CI now
This PR need to re-add the lgtm label

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c588dae into kubeflow:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@jimexist jimexist Awaiting requested review from jimexist

@swiftdiaries swiftdiaries Awaiting requested review from swiftdiaries

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[chore] Remove tfjob dashboard
5 participants
@ChanYiLin @coveralls @TravisBuddy @k8s-ci-robot @gaocegege