Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope presubmits by version #1008

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented May 23, 2019

Only run v1beta2 tests if relevant or common code is changed. Same for v1.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling 8b4f6ab on richardsliu:scope_tests into 4a46eba on kubeflow:master.

@richardsliu
Copy link
Contributor Author

/assign @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a56fc9b into kubeflow:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants