Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete v1beta1 #1004

Merged
merged 3 commits into from
May 23, 2019
Merged

Delete v1beta1 #1004

merged 3 commits into from
May 23, 2019

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented May 23, 2019 •
edited by jlewi
Loading

This change is Reviewable

gaocegege
gaocegege reviewed May 23, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 76.744% when pulling cb6670b on richardsliu:delete_v1beta1 into d5d783c on kubeflow:master.

@ScorpioCPH
Copy link
Member

/approved

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f41a5e5 into kubeflow:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@jimexist jimexist Awaiting requested review from jimexist

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardsliu @coveralls @ScorpioCPH @johnugeorge @k8s-ci-robot @gaocegege