Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1alpha2][log] Use logrus instead of glog in service_control #635

Closed
gaocegege opened this issue Jun 12, 2018 · 2 comments · Fixed by #695
Closed

[v1alpha2][log] Use logrus instead of glog in service_control #635

gaocegege opened this issue Jun 12, 2018 · 2 comments · Fixed by #695
Labels
api/v1alpha2 area/logging good first issue priority/p3

Comments

@gaocegege
Copy link
Member

We copied the code in Kubernetes and they use glog. Then we need to update it.
@gaocegege
Copy link
Member Author

/assign @codeflitting

@k8s-ci-robot
Copy link

@gaocegege: GitHub didn't allow me to assign the following users: codeflitting.

Note that only kubeflow members and repo collaborators can be assigned.

In response to this:

/assign @codeflitting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codeflitting codeflitting mentioned this issue Jun 25, 2018
Merged
jlewi added a commit to jlewi/k8s that referenced this issue Jul 30, 2018
@jlewi
Improve meta information in log messages to make it easier to debug j…
1442adf 
…obs.

* Use <namespace>.<name> as opposed to <namespace>/<name>; the former
  is more consistent with K8s style.

* Add functions for constructing loggers for the pod and unstructured meta
  information. This will allow us to appropriately tag a number of log
  messages with meta information.

* Update a bunch of log messages which weren't logging info with
  appropriate meta information.

* Make json log formatting the default; this was the case for v1.
  json logging should be the default because otherwise we lose the meta
  information in the logs. With json logs its always possible to filter/reformat
  the log entries if you don't care about the metainformation.

Related to:
  kubeflow#24 Use logrus
  kubeflow#635
@jlewi jlewi mentioned this issue Jul 30, 2018
Merged
k8s-ci-robot pushed a commit that referenced this issue Aug 1, 2018
@jlewi @k8s-ci-robot
Improve meta information in log messages to make it easier to debug j…
90259e7 
…obs (#765)

* Improve meta information in log messages to make it easier to debug jobs.

* Use <namespace>.<name> as opposed to <namespace>/<name>; the former
  is more consistent with K8s style.

* Add functions for constructing loggers for the pod and unstructured meta
  information. This will allow us to appropriately tag a number of log
  messages with meta information.

* Update a bunch of log messages which weren't logging info with
  appropriate meta information.

* Make json log formatting the default; this was the case for v1.
  json logging should be the default because otherwise we lose the meta
  information in the logs. With json logs its always possible to filter/reformat
  the log entries if you don't care about the metainformation.

Related to:
  #24 Use logrus
  #635

* Fix lint by running; goimports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api/v1alpha2 area/logging good first issue priority/p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use logrus instead of glog in service_control
2 participants
@gaocegege @k8s-ci-robot