Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests for all frameworks #1311

Closed
Jeffwan opened this issue Jul 29, 2021 · 9 comments
Closed

Enable tests for all frameworks #1311

Jeffwan opened this issue Jul 29, 2021 · 9 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Jul 29, 2021

Current project only have test cases for Tensorflow. We should enable tests for all rest frameworks in the pipeline.

  1. Move all test cases to the repo
  2. Rewrite CI pipeline to includes these steps (build images, run e2e tests etc)
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 29, 2021

/help

@google-oss-robot
Copy link

@Jeffwan:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thunderboltsid
Copy link
Contributor

/assign

@andreyvelich
Copy link
Member

andreyvelich commented Sep 22, 2021

As we discussed today on the AutoML and Training meeting, we want to use Python scripts instead of deprecated ksonnet to build Argo Workflows for the AWS CI infra.
This is the current tf-operator Argo workflow: https://github.com/kubeflow/tf-operator/blob/master/test/workflows/components/workflows.libsonnet#L98-L327. For all operators they will be similar.

To transfer this workflow to Python we should do the similar steps as for the Kubeflow Notebook Controller:

  • Add python_paths to prow config. I think for us it will be kubeflow/tf-operator/test/e2e or kubeflow/tf-operator/test/workflows. We can think about the folder name to store python scripts.

  • Define py_func which creates Argo Workflow.

  • Create function which returns Argo Workflow with all required steps.

I think we can simplify workflow utils for the Training Operator to leave only necessary functions.

Does it sound good @Jeffwan @thunderboltsid @johnugeorge ?

cc @kimwnasptd for reference.

@andreyvelich
Copy link
Member

I created PR in Katib: kubeflow/katib#1674 to switch from ksonnet to python.
@thunderboltsid @Jeffwan I think we can keep the similar process for Training Operator.

@gaocegege
Copy link
Member

we want to use Python scripts instead of deprecated ksonnet to build Argo Workflows for the AWS CI infra.

Sounds really good

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 24, 2021

Using python, we can still leverage kubeflow/testing common code base, right?
I am thinking if we should write test codes in golang later. Bring up this topic since we will anyway rewrite the tests.

@andreyvelich
Copy link
Member

Using python, we can still leverage kubeflow/testing common code base, right?
I am thinking if we should write test codes in golang later. Bring up this topic since we will anyway rewrite the tests.

@Jeffwan Yes, we can.
Check here: https://github.com/kubeflow/katib/blob/f2af5d5ab7385eedbb903060dcf64f6b42fcdcf6/test/e2e/v1beta1/argo_workflow.py#L312.

I am using shared infra utils.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants