Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWNERS: Add ChanYiLin as reviewers #784

Merged
merged 2 commits into from
Aug 20, 2018
Merged

OWNERS: Add ChanYiLin as reviewers #784

merged 2 commits into from
Aug 20, 2018

Conversation

ChanYiLin
Copy link
Member

@ChanYiLin ChanYiLin commented Aug 20, 2018

/assign @gaocegege
Thanks!


This change is Reviewable

@gaocegege
Copy link
Member

/ok-to-test

OWNERS Outdated
@@ -8,6 +8,7 @@ reviewers:
- ankushagarwal
- cheyang
- codeflitting
- ChanYiLin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name before cheyang

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@gaocegege
Copy link
Member

gaocegege commented Aug 20, 2018

/lgtm
/approve

Thanks for your interest and please help us review the PRs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 57.957% when pulling 705addd on ChanYiLin:master into 5fa4dca on kubeflow:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 57.957% when pulling 705addd on ChanYiLin:master into 5fa4dca on kubeflow:master.

@coveralls
Copy link

coveralls commented Aug 20, 2018

Coverage Status

Coverage remained the same at 58.026% when pulling e024a96 on ChanYiLin:master into 5fa4dca on kubeflow:master.

@k8s-ci-robot k8s-ci-robot merged commit 78cfba1 into kubeflow:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants