Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

and some safety check #683

Merged
merged 1 commit into from
Jun 19, 2018
Merged

and some safety check #683

merged 1 commit into from
Jun 19, 2018

Conversation

u2takey
Copy link
Contributor

@u2takey u2takey commented Jun 16, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 16, 2018

Coverage Status

Coverage decreased (-14.8%) to 57.741% when pulling 8b82f04 on u2takey:master into 56ff370 on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test

@u2takey
Copy link
Contributor Author

u2takey commented Jun 17, 2018

/retest

1 similar comment
@u2takey
Copy link
Contributor Author

u2takey commented Jun 17, 2018

/retest

@gaocegege
Copy link
Member

/retest

The failure is not caused by your PR, I will take a look.

@gaocegege
Copy link
Member

/lgtm
/approve

Thanks for your contribution!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6362623 into kubeflow:master Jun 19, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants