Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dep and vendor #663

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Update dep and vendor #663

merged 1 commit into from
Jun 14, 2018

Conversation

xychu
Copy link
Contributor

@xychu xychu commented Jun 14, 2018 •
edited by jlewi
Loading

Including:

  • add missing pkgs to Gopkg.toml
  • add prune rules
  • update vendor/ via dep ensure

This change is Reviewable

@xychu
Update dep and vendor
e78b043 
Including:
- add missing pkgs to Gopkg.toml
- add prune rules
- update vendor/ via `dep ensure`
@k8s-ci-robot k8s-ci-robot requested review from ddysher and lluunn June 14, 2018 11:00
@xychu
Copy link
Contributor Author

xychu commented Jun 14, 2018

I got the missing pkgs by:

  • delete Gopkg.toml and Gopkg.lock
  • run dep init to generate new toml file
  • git diff Gopkg.toml to see which is new added

@coveralls
Copy link

coveralls commented Jun 14, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 57.487% when pulling e78b043 on xychu:update-dep into 4634c93 on kubeflow:master.

@gaocegege
Copy link
Member

/approve
/lgtm

Thanks for your contribution.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8fa47e into kubeflow:master Jun 14, 2018
@xychu xychu deleted the update-dep branch June 15, 2018 01:55
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
@xychu
Update dep and vendor (kubeflow#663)
b7b771b 
Including:
- add missing pkgs to Gopkg.toml
- add prune rules
- update vendor/ via `dep ensure`
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
@xychu @k8s-ci-robot
Update dep and vendor (kubeflow#663)
5362194 
Including:
- add missing pkgs to Gopkg.toml
- add prune rules
- update vendor/ via `dep ensure`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddysher ddysher Awaiting requested review from ddysher

@lluunn lluunn Awaiting requested review from lluunn

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xychu @coveralls @gaocegege @k8s-ci-robot