We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

Coverage increased (+2.6%) to 50.706% when pulling 76be44a on u2takey:master into 846fd38 on kubeflow:master.

Thanks for your contribution!

Please fix the error in Travis CI

And, your commit belongs to a unrecognised author, could you please commit it with your own git account?

/ok-to-test

CLA updated

@u2takey I think the commit author should be yourself, or it can not pass the CLA check.

CLAs look good, thanks!

thx @gaocegege, cla issue fixed

Generally LGTM, would you mind adding some unit test cases? If you have no time I can do it for you.

Thanks for your contribution!

@gaocegege some test added

@ScorpioCPH As for annotations I think it works for me. As for the labels, I think the labels used in pod are hardly used in jobs. But if they have the same key, it is indeed a problem.

@u2takey WDYT

@ScorpioCPH sorry to wrong commit message. Not copy labels from tfjob, but from tfjob's PodTemplateSpec. In tfjob, what we defined is a PodTemplateSpec, so, as a user, i expect pod tfoperator created also follow this PodTemplateSpec. And this is behaviour in old version of tfoperator .

@ScorpioCPH

Does it LGTY?

@u2takey FYI, we have done this in v1alpha2, code is here.

SGTM to add this in master branch :)

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here