-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename InClusterConfig() to GetClusterConfig() #137
Conversation
use env var KUBECONFIG to retrieve kubeconfig (same as kubectl)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Hi @huangyue18. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks for the fix. |
@huangyue18 Can you sign the CLA please? |
Looks like @huangyue18 already signed the CLA. Will try to retrigger the check. I signed it! |
I signed it! |
@huangyue18 I think you need to add the "I signed it!" comment to trigger the CLA bot; looks like I can't do it. |
I signed it! |
CLAs look good, thanks! |
rename InClusterConfig() to GetClusterConfig(), remove todo
also use env var KUBECONFIG to retrieve kubeconfig (same as kubectl)