Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename InClusterConfig() to GetClusterConfig() #137

Merged
merged 1 commit into from
Nov 15, 2017
Merged

rename InClusterConfig() to GetClusterConfig() #137

merged 1 commit into from
Nov 15, 2017

Conversation

moon03432
Copy link
Contributor

@moon03432 moon03432 commented Nov 14, 2017

rename InClusterConfig() to GetClusterConfig(), remove todo
also use env var KUBECONFIG to retrieve kubeconfig (same as kubectl)

use env var KUBECONFIG to retrieve kubeconfig (same as kubectl)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@k8s-ci-robot
Copy link

Hi @huangyue18. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@moon03432 moon03432 changed the title rename InClusterConfig() to GetClusterConfig() (TODO) rename InClusterConfig() to GetClusterConfig() Nov 14, 2017
@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2017

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2017

Thanks for the fix.

@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2017

@huangyue18 Can you sign the CLA please?

@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2017

Looks like @huangyue18 already signed the CLA. Will try to retrigger the check.

I signed it!

@jlewi jlewi closed this Nov 14, 2017
@jlewi jlewi reopened this Nov 14, 2017
@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2017

I signed it!

@jlewi
Copy link
Contributor

jlewi commented Nov 14, 2017

@huangyue18 I think you need to add the "I signed it!" comment to trigger the CLA bot; looks like I can't do it.

@moon03432
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jlewi jlewi merged commit 24412ea into kubeflow:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants