Turn release.py into a binary to build the artifacts for all the different contexts #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent modes.
* We have multiple contexts in which we want to build the images and other artifacts
* local
* Tests
* releases
* This CL changes release.py so handle all three cases.
* This increases code reuse and provides greater consistency.
* Prior to this CL building the operator image didn't build other artifacts;
notably the helm package.
* This change is intended to facilitate transitioning to a workflow system
for running more complex test and release workflows.
* Currently the test infrastructure is using runner.py to build the
images. The tests don't actually build the helm package.
* We want to replace runner.py with a binary (release.py) that can
be invoked to build the artifacts. This way our test/release workflow
can just invoke that binary.
ScorpioCPH
reviewed
Nov 10, 2017
| mkdir -p ${GOPATH}/src/github.com/jlewi | ||
| ln -sf ${GIT_TRAINING} ${GOPATH}/src/mlkube.io | ||
| mkdir -p ${GOPATH}/src/github.com/tensorflow | ||
| ln -sf ${GIT_TRAINING} ${GOPATH}/src/github.com/tensorflow/k8s |
There was a problem hiding this comment.
It seems like ${GIT_TRAINING} is the same as ${GOPATH}/src/github.com/tensorflow/k8s in some case.
There was a problem hiding this comment.
I'm not sure I understand the question. Its certainly possible to check out the repository directly into your GOLANG src tree in which case you don't need to create a symbolic link.
jlewi
changed the title
|
@jimexist I don't like writing complex make files. If we need a more complex build system I'm more inclined to switch to using bazel. I think the approach of using python scripts should be compatible with bazel because we can create custom build rules that would build tools and then use those tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple contexts in which we want to build the images and other artifacts
* local
* Tests
* releases
This CL changes release.py so handle all three cases.
notably the helm package.
This change is intended to facilitate transitioning to a workflow system
for running more complex test and release workflows.
images. The tests don't actually build the helm package.
be invoked to build the artifacts. This way our test/release workflow
can just invoke that binary.