Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Observe the creation when failed to create the pod #1236

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix: Observe the creation when failed to create the pod #1236

merged 1 commit into from
Feb 4, 2021

Conversation

gaocegege
Copy link
Member

Fix #1221

Signed-off-by: cegao cegao@tencent.com

@gaocegege
feat: Add creationObserved when creating pods has errors
c8c85dc 
Signed-off-by: cegao <cegao@tencent.com>
@gaocegege
Copy link
Member Author

\cc @ultraji

PTAL

/cc @ChanYiLin @terrytangyuan

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 71.831% when pulling c8c85dc on gaocegege:expect into c13a9e4 on kubeflow:master.

@ultraji
Copy link

ultraji commented Feb 3, 2021

/lgtm

@k8s-ci-robot
Copy link

@ultraji: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aws-kf-ci-bot
Copy link
Contributor

@gaocegege: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit c8c85dc link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

terrytangyuan
terrytangyuan approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit 4f69069 into kubeflow:master Feb 4, 2021
@gaocegege gaocegege deleted the expect branch February 4, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

Assignees

@terrytangyuan terrytangyuan

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I have some questions about the function createNewPod in pkg/controller.v1/tensorflow/pod.go
6 participants
@gaocegege @coveralls @ultraji @k8s-ci-robot @aws-kf-ci-bot @terrytangyuan