Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tf-operator test in py3 #1133

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Feb 18, 2020

httplib has been renamed as http.client: https://stackoverflow.com/questions/13778252/import-httplib-importerror-no-module-named-httplib

adding new script to prevent breaking changes.

Related: kubeflow/kfctl#228


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.512% when pulling 9deead5 on gabrielwen:py3-test into 9238906 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @jinchihe

/lgtm

@jinchihe
Copy link
Member

/lgtm
/approve

@gaocegege
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00ea3ec into kubeflow:master Feb 18, 2020
@gabrielwen gabrielwen deleted the py3-test branch February 18, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants