Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): show correct namespace and name when deleting job through dashboard #1044

Merged
merged 1 commit into from
Jul 16, 2019
Merged

fix(UI): show correct namespace and name when deleting job through dashboard #1044

merged 1 commit into from
Jul 16, 2019

Conversation

gbin10533
Copy link
Contributor

@gbin10533 gbin10533 commented Jul 15, 2019 •
edited by jlewi
Loading

When I try to delete job through the dashboard, I notice that the message is always:

Are you sure you want to delete TFJob "test" in namespace "test"?

So I replace "test" with real namespace and name of the job.

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @gbin10533. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling e410287 on gbin10533:master into 67b5571 on kubeflow:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling e410287 on gbin10533:master into 67b5571 on kubeflow:master.

@gaocegege gaocegege changed the title show correct namespace and name when deleting job through dashboard fix(UI): show correct namespace and name when deleting job through dashboard Jul 16, 2019
gaocegege
gaocegege reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

Exception occured; type <type 'exceptions.RuntimeError'> message Request to https://35.243.134.169/api/v1/namespaces/default/services/estimator-runconfig-tests-v1beta2-worker-1:2222/proxy/runconfig exited with status code: 503

Weird, I will retest it.

/retest

@gaocegege
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit b17a217 into kubeflow:master Jul 16, 2019
@gaocegege
Copy link
Member

@gbin10533

Thanks for your contribution! 🎉 👍

@gbin10533
Copy link
Contributor Author

@gaocegege

This is my first PR, I'm very excited, thank you so much!

@gaocegege
Copy link
Member

@gbin10533

Welcome more contributions!

ChenYi015 pushed a commit to ChenYi015/training-operator that referenced this pull request Nov 6, 2024
@gbin10533 @ChenYi015
show correct namespace and name when deleting job through dashboard (k…
83457ad 
…ubeflow#1044)

(cherry picked from commit b17a217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@jimexist jimexist Awaiting requested review from jimexist

@swiftdiaries swiftdiaries Awaiting requested review from swiftdiaries

Assignees

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbin10533 @k8s-ci-robot @coveralls @gaocegege