Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wackxu as reviewers #1017

Merged
merged 1 commit into from
May 28, 2019
Merged

Add wackxu as reviewers #1017

merged 1 commit into from
May 28, 2019

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 28, 2019

I would like to help review PRs if it is ok.

/assign @gaocegege @richardsliu


This change is Reviewable

@gaocegege
Copy link
Member

/lgtm

Are you invited by admins to be an org member?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling 9b9bcc4 on wackxu:patch-1 into 407753d on kubeflow:master.

@wackxu
Copy link
Contributor Author

wackxu commented May 28, 2019

@gaocegege Not yet, but I have asked for help in the slack #community channel yesterday.

@gaocegege
Copy link
Member

Then we could merge it first. After the invitation, you should be able to be invited by the bot to help us review PRs

@gaocegege
Copy link
Member

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 61f9ea6 into kubeflow:master May 28, 2019
@wackxu
Copy link
Contributor Author

wackxu commented May 28, 2019

@gaocegege Got it, thanks

@wackxu wackxu deleted the patch-1 branch May 28, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants