Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the restriction that the container should be named "tensorflow" #563

Closed
ankushagarwal opened this issue Apr 27, 2018 · 8 comments

Comments

@ankushagarwal
Copy link

Right now to deploy a TFJob, the pod must contain a container named tensorflow. The idea with this was to support sidecar containers. But if there is only a single container for a worker, we shouldn't enforce the restriction that it should be named tensorflow

/cc @jlewi @gaocegege

@gaocegege
Copy link
Member

SGTM.

@jlewi
Copy link
Contributor

jlewi commented May 8, 2018

What if users want to add sidecars to do things like

  • handle logging
  • download/stage data e.g. in the case of Pachyderm

I think assuming there will be only one container is two limiting

@ankushagarwal
Copy link
Author

The constraint of naming the container 'tensorflow' is fine when there are sidecars. But if there is only a single container per pod (which is not an uncommon scenario), it doesn't make sense of have this restriction.

@jlewi
Copy link
Contributor

jlewi commented May 8, 2018

So we could drop the requirement that a container be named TensorFlow if there is a single container but I'm not sure I like the idea of only imposing the requirement of having a container named TensorFlow when there is more than 1 container.

If there is a single container that isn't named "TensorFlow" can't we just provide a very clear error message that explains how to fix things?

@gaocegege
Copy link
Member

I meet a problem when I am fixing #532 , I found that it is hard to set the default port for tensorflow container if we do not know which one is it.

Consider that we have two containers in the pod and one is tensorflow container named "my-name", and a sidecar named "sidecar". We need to set the default port for the tensorflow container since it does not have one. Then we can not do it without the name "tensorflow" since we do not know which one is the real tensorflow container.

@jlewi
Copy link
Contributor

jlewi commented Jul 3, 2018

What do we want to do in 0.3.0? Do we leave the behavior as is or do we change it?

@gaocegege
Copy link
Member

We can not change it since we need it to find the port and generate cluster spec.

@jlewi
Copy link
Contributor

jlewi commented Jul 6, 2018

Per the above closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants