Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1alpha2] Potential bugs when there is one worker succeeded #538

Closed
gaocegege opened this issue Apr 16, 2018 · 3 comments
Closed

[v1alpha2] Potential bugs when there is one worker succeeded #538

gaocegege opened this issue Apr 16, 2018 · 3 comments
Assignees
@gaocegege
Labels
api/v1alpha2 kind/bug priority/p0

Comments

@gaocegege
Copy link
Member

Test Case:

"Distributed TFJob (4 workers, 2 PS) is created, 2 workers, 1 PS are pending, 1 worker is succeeded": {
			4, 2,
			nil, true,
			2, 0, 1, 0,
			1, 0, 0, 0,
			3, 1,
			1, 0, 1,
			3, 0, 0,
			2, 0, 0,
			&tfJobRunning, tfJobRunningReason,
			false,
		},
@gaocegege gaocegege mentioned this issue Apr 16, 2018
Merged
@gaocegege gaocegege self-assigned this Apr 16, 2018
@jlewi
Copy link
Contributor

jlewi commented Apr 16, 2018

Its not clear to me from the issue description what the expected outcome is and what the actual outcome is.

@gaocegege
Copy link
Member Author

The description is we expect not to create new pods for the succeeded workers but we do create now.

@gaocegege
Copy link
Member Author

Close in #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaocegege gaocegege

Labels
api/v1alpha2 kind/bug priority/p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @gaocegege