Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Fix go vet errors which not caught by the compilers #395

Closed
gaocegege opened this issue Feb 17, 2018 · 1 comment
Closed

[enhancement] Fix go vet errors which not caught by the compilers #395

gaocegege opened this issue Feb 17, 2018 · 1 comment
Labels
difficulty/low good first issue priority/p3

Comments

@gaocegege
Copy link
Member

gaocegege commented Feb 17, 2018 •
edited
Loading

There are some errors in our code but it won't caught by the compilers:

cmd/tf-operator/app/server.go:129: unreachable code
exit status 1
dashboard/backend/handler/api_handler.go:36: struct field tfJobs has json tag but is not exported
dashboard/backend/handler/api_handler.go:41: struct field namespaces has json tag but is not exported
exit status 1

You can get them by running:

go vet $(go list ./... | grep -v /vendor/)
@swiftdiaries swiftdiaries mentioned this issue Feb 22, 2018
Merged
jlewi pushed a commit that referenced this issue Feb 22, 2018
@swiftdiaries @jlewi
Addressing go vet errors (#397)
87c4bba 
Addressing #395.

There are some errors in our code but it won't caught by the compilers

$ go vet $(go list ./... | grep -v /vendor/)
Output:

cmd/tf-operator/app/server.go:129: unreachable code
exit status 1
dashboard/backend/handler/api_handler.go:36: struct field tfJobs has json tag but is not exported
dashboard/backend/handler/api_handler.go:41: struct field namespaces has json tag but is not exported
exit status 1
@gaocegege
Copy link
Member Author

@swiftdiaries Thanks for your contribution and I am closing the issue now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/low good first issue priority/p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaocegege