Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the ENV MY_POD_NAMESPACE and MY_POD_NAME #341

Closed
ScorpioCPH opened this issue Jan 23, 2018 · 0 comments · Fixed by #348
Closed

Deprecate the ENV MY_POD_NAMESPACE and MY_POD_NAME #341

ScorpioCPH opened this issue Jan 23, 2018 · 0 comments · Fixed by #348
Labels
kind/feature
Milestone
Kubecon Europe

Comments

@ScorpioCPH
Copy link
Member

As we discussed here:

  • We decide to create CRD object: TFJob from CRD yaml file
  • Set namespace in this CRD yaml file

So I propose to deprecate the ENV MY_POD_NAMESPACE and MY_POD_NAME.

@jlewi WDYT?
@jlewi jlewi added this to the Kubecon Europe milestone Jan 23, 2018
@ScorpioCPH ScorpioCPH mentioned this issue Jan 26, 2018
Merged
@jlewi jlewi closed this as completed in #348 Feb 2, 2018
jlewi pushed a commit that referenced this issue Feb 2, 2018
@ScorpioCPH @jlewi
Deprecate MY_POD_NAME and use default namespace (#348)
e2b13e0 
This PR fixes #341:

Deprecate the ENV MY_POD_NAMESPACE and MY_POD_NAME
And use NamespaceDefault by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
Kubecon Europe
Development

Successfully merging a pull request may close this issue.

Deprecate the ENV MY_POD_NAME and use default namespace ScorpioCPH/tf-operator
3 participants
@jlewi @gaocegege @ScorpioCPH