Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFJob completion with active services/endpoints resources #1191

Closed
shaowei-su opened this issue Oct 16, 2020 · 3 comments
Closed

TFJob completion with active services/endpoints resources #1191

shaowei-su opened this issue Oct 16, 2020 · 3 comments
Labels
area/front-end

Comments

@shaowei-su
Copy link
Contributor

Upon job completion, by settings cleanPodPolicy properly, workers pods are properly terminated. However, services/endpoints are not cleaned up by the controller, e.g.
Screen Shot 2020-10-16 at 09 40 35

Is this by design to keep those services around?
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.72
area/operator 0.90

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.61

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@shaowei-su
Copy link
Contributor Author

After some digging up: it seems that Pod with completed / failed status won't be deleted in the current implementation:
https://github.com/kubeflow/common/blob/master/pkg/controller.v1/common/job.go#L37
since pod and service deletion are tied together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/front-end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shaowei-su