Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync kubeflow pipelines manifests 2.2.0 #2700

Merged
merged 4 commits into from
May 2, 2024
Merged

Sync kubeflow pipelines manifests 2.2.0 #2700

merged 4 commits into from
May 2, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout
Update kubeflow/pipelines manifests from 2.2.0
3a9a6ff 
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update sync-pipelines-manifests.sh
4f6a619 
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update kubeflow/pipelines manifests from 2.2.0
21a97a6 
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Delete sync-kfp-tekton-manifests.sh
9bb19f7 
See kubeflow/pipelines#10702

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout requested a review from rimolive May 2, 2024 08:52
@juliusvonkohout juliusvonkohout self-assigned this May 2, 2024
@google-oss-prow google-oss-prow bot requested review from kimwnasptd and zijianjoy May 2, 2024 08:52
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented May 2, 2024 •
edited
Loading

In a follow up PR @diegolovison should take a look at the line | Kubeflow Tekton Pipelines | apps/kfp-tekton/upstream | [2.0.5](https://github.com/kubeflow/kfp-tekton/tree/2.0.5/manifests/kustomize) |. Maybe we can just drop it entirely and change the line above to include Tekton.

We should at least add a deprecation warning and remove the seperate tekton manifests and readme stuff in this or the next release.

@rimolive
Copy link
Member

rimolive commented May 2, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 2, 2024
@google-oss-prow google-oss-prow bot merged commit 98f52e2 into master May 2, 2024
7 of 8 checks passed
@juliusvonkohout juliusvonkohout mentioned this pull request May 7, 2024
Closed
@juliusvonkohout juliusvonkohout deleted the sync-kubeflow-pipelines-manifests-2.2.0 branch May 16, 2024 12:38
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
@juliusvonkohout
Sync kubeflow pipelines manifests 2.2.0 (kubeflow#2700)
5046abe 
* Update kubeflow/pipelines manifests from 2.2.0

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update sync-pipelines-manifests.sh

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update kubeflow/pipelines manifests from 2.2.0

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Delete sync-kfp-tekton-manifests.sh

See kubeflow/pipelines#10702

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive Awaiting requested review from rimolive

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@rimolive rimolive

@juliusvonkohout juliusvonkohout

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusvonkohout @rimolive