Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PatrickXYS as tests folder approver #1598

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add PatrickXYS as tests folder approver #1598

merged 1 commit into from
Oct 30, 2020

Conversation

PatrickXYS
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
I've been continuously contributing to manifests repo and will be adding E2E test back which include manifests+kfctl.

Adding myself as tests folder approver.

Here is my contribution list:
https://github.com/kubeflow/manifests/pulls/PatrickXYS

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@PatrickXYS
Copy link
Member Author

/cc @Jeffwan @andreyvelich @Bobgy @gaocegege @johnugeorge @krishnadurai

@PatrickXYS
Copy link
Member Author

/test kubeflow-manifests-presubmit

andreyvelich
andreyvelich reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work @PatrickXYS!
/lgtm

@Jeffwan
Copy link
Member

Jeffwan commented Oct 30, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c903ce8 into kubeflow:master Oct 30, 2020
@PatrickXYS PatrickXYS deleted the add_patrickxys branch October 30, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@Bobgy Bobgy Awaiting requested review from Bobgy

@gaocegege gaocegege Awaiting requested review from gaocegege

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@andreyvelich andreyvelich

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PatrickXYS @kubeflow-bot @Jeffwan @k8s-ci-robot @andreyvelich