fix: running code-server notebook behind proxy #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
ederign
approved these changes
Nov 5, 2024
|
/lgtm |
3 tasks
|
I am self approving because @kimwnasptd seems to not be active, and this is a trivial change that I would like to cut a patch release for. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
Currently, the code-server notebook image (VSCode) will not work properly when behind a proxy that changes the hostname, as code-server requires that the x-forwarded-for match the actual HTTP host header otherwise it gives an error like this:
What's the solution?
As documented upstream in coder/code-server#4443, the solution is to start code-server with the
--trusted-origins "*"parameter.