Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files #7643

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Sep 6, 2024

As part of migrating code out of this repo #7549, there is a bunch of code on this repo which does nothing anymore.

This PR removes the following content from the kubeflow/kubeflow repo:

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

@kimwnasptd if you agree with all these removals, please LGTM.

After that, @andreyvelich can approve (it requires a root approver).

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @thesuperzapper!
Overall, lgtm.
Should we also remove security folder: https://github.com/thesuperzapper/kubeflow/tree/remove-unused-files/security @juliusvonkohout @akgraner ?

/assign @kubeflow/wg-manifests-leads @kubeflow/wg-notebooks-leads @kubeflow/kubeflow-steering-committee

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Sep 6, 2024

We should probably move the security folder to kubeflow/manifests. But this can be done in another PR.

@andreyvelich
Copy link
Member

@juliusvonkohout Can you submit PR to move it under manifests repo and remove it from kubeflow/kubeflow ?

@thesuperzapper
Copy link
Member Author

@andreyvelich @juliusvonkohout I think security info should be under kubeflow/community with the rest of the governance docs, otherwise old versions of the information will end up snapshotted with old versions.

@andreyvelich
Copy link
Member

I think security info should be under kubeflow/community with the rest of the governance docs, otherwise old versions of the information will end up snapshotted with old versions.

I am fine with the both as long as maintainers can take care of those assets.

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper
Copy link
Member Author

@andreyvelich I have also removed the ./security folder in this PR and raised a seperate one to move it to kubeflow/community:

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thesuperzapper!
/lgtm
/assign @kubeflow/kubeflow-steering-committee

@juliusvonkohout
Copy link
Member

/lgtm

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 01258d8 into kubeflow:master Sep 10, 2024
3 checks passed
@thesuperzapper thesuperzapper deleted the remove-unused-files branch September 10, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants