-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused files #7643
Remove unused files #7643
Conversation
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@kimwnasptd if you agree with all these removals, please LGTM. After that, @andreyvelich can approve (it requires a root approver). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @thesuperzapper!
Overall, lgtm.
Should we also remove security folder: https://github.com/thesuperzapper/kubeflow/tree/remove-unused-files/security @juliusvonkohout @akgraner ?
/assign @kubeflow/wg-manifests-leads @kubeflow/wg-notebooks-leads @kubeflow/kubeflow-steering-committee
We should probably move the security folder to kubeflow/manifests. But this can be done in another PR. |
@juliusvonkohout Can you submit PR to move it under manifests repo and remove it from |
@andreyvelich @juliusvonkohout I think security info should be under |
I am fine with the both as long as maintainers can take care of those assets. |
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@andreyvelich I have also removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thesuperzapper!
/lgtm
/assign @kubeflow/kubeflow-steering-committee
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As part of migrating code out of this repo #7549, there is a bunch of code on this repo which does nothing anymore.
This PR removes the following content from the
kubeflow/kubeflow
repo:./docs/gke/
:./docs_dev/
./py/
:./security/
:kubeflow/community
, see:kubeflow/kubeflow
community#749./testing/gh-actions/
.pylintrc
.style.yapf
prow_config.yaml