/cc @kubeflow/wg-training-leads

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: kubeflow/wg-training-leads.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

@andreyvelich, I'll probably have time to look at this by the end of this week! I'll keep everyone posted!

@andreyvelich, I'll probably have time to look at this by the end of this week! I'll keep everyone posted!

Thank you for much for your time!
@kubeflow/wg-notebooks-leads Please can you trigger the GitHub actions ?

cc @james-jwu @zijianjoy I think, you also should be able to trigger GitHub actions.

Hi @kimwnasptd @orfeas-k @ederign are we ready to merge this PR to unblock Katib E2Es ?

@tariq-hasan Please can you check why Cypress tests fails ?

I am looking into it.

The JWA Frontend Tests failed when @rimolive triggered Github Actions for this PR but when I ran the same test in a copy of the branch in my fork it succeeded: https://github.com/tariq-hasan/kubeflow/actions/runs/10748617448.

If we can re-trigger the Github Actions for this PR perhaps we can understand the issue better.

I triggered them just now @tariq-hasan

@tariq-hasan It looks like the cypress tests are failing with this error:

1 failing
  1) New notebook form
       should auto update mount value when name change:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `.last[data-cy="data volumes"]`, but never found it.
      at Context.eval (webpack://frontend/./cypress/e2e/form-page.cy.ts:[49](https://github.com/kubeflow/kubeflow/actions/runs/10748577742/job/29933500341#step:6:50):7)

When you get a chance, please can you try to debug it locally ?

Any thoughts @kimwnasptd @ederign ?

Is the issue occurring due to test flakiness?

If so, do you have any suggestion on how to remove the error? @kimwnasptd @ederign

It looks to be that the element to be clicked is detached from the DOM.

@thesuperzapper For jupyter I upgraded Cypress to 13.14.0 instead of 13.13.3: 8a74e01#diff-9f86874cf004f00e992b404d1a7469dca7d5a93f3def85ab82c7b1e998ccd38cL68.

I was wondering if you would be able to trigger the workflow again.

This is actually odd behavior. The tests happen to succeed or fail at random when running on my local or on a copy of the branch in Github Actions.

I have replaced Cypress with Playwright for the e2e tests in Jupyter. Can you please re-run the workflows? @thesuperzapper

Thanks for running the workflows.

JWA Frontend Tests have passed finally!

Can we re-run CentralDashboard-angular Frontend Tests? I have not seen this fail before.

All the tests have passed. Thanks @andreyvelich and @thesuperzapper.

Please review and let me know if anything needs to be changed @kimwnasptd @thesuperzapper @orfeas-k.

Thank you for this effort @tariq-hasan!
@ederign @thesuperzapper @kimwnasptd @Griffin-Sullivan Please can you /lgtm this PR since it will unblock the Katib UI development.
/lgtm

@tariq-hasan Did you get a chance to deploy your Docker images to verify that all WebApps (Jupyter WebApp, TensorBoard, Volumes WebApp) are working ?

Hi @andreyvelich I am deploying the Docker images to verify that all WebApps (Jupyter WebApp, TensorBoard, Volumes WebApp) are working. I will update here shortly.

There was a flag removed from the build scripts that I have added back in. All the web apps - Jupyter, TensorBoards and Volumes - are functional from my local now when deployed through built Docker images.

Thank you for all of these tests @tariq-hasan!
We should be fine to merge this and unblock the Katib UI CI/CD.
@kimwnasptd @juliusvonkohout @thesuperzapper @ederign Can you /lgtm this please ?
/lgtm

/lgtm

Since we definitely need this to reduce CVEs as well. We should even go to node 22 in follow up prs https://nodejs.org/en/about/previous-releases#release-schedule

/assign @thesuperzapper

Since I do not have approver rights for this repository.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here