Fix Python linting #7060
Merged
Fix Python linting #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
google-oss-prow
bot
requested review from
davidspek,
elikatsis,
MartinForReal,
StefanoFioravanzo and
thesuperzapper
54 tasks
|
Thanks for the effort! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elikatsis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* gh-action: Workflow for testing python lint Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * lint: Run autopep8 to lint files Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * linting: Manual changes Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* gh-action: Workflow for testing python lint Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * lint: Run autopep8 to lint files Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * linting: Manual changes Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* gh-action: Workflow for testing python lint Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * lint: Run autopep8 to lint files Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * linting: Manual changes Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* gh-action: Workflow for testing python lint Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * lint: Run autopep8 to lint files Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * linting: Manual changes Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* gh-action: Workflow for testing python lint Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * lint: Run autopep8 to lint files Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * linting: Manual changes Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have a lot of python files but do not do any linting checks on any PRs. As a result running
flake8on the repo produces more than 250 different warnings.In this PR I've:
.pyfile is changedflake8to ensure the code is properly formattedIn order to fix most of the errors I used
autopep8, which got the errors down to 90. Then some minor edits were done for the rest of the files.