notebook-controller: Extend tests for using images of each PR #6830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
google-oss-prow
bot
requested review from
elikatsis,
MartinForReal and
yanniszark
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…ow/kubeflow#6830) * Introduce intergration test workflow for notebook-controller Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…ow/kubeflow#6830) * Introduce intergration test workflow for notebook-controller Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…ow/kubeflow#6830) * Introduce intergration test workflow for notebook-controller Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…ow/kubeflow#6830) * Introduce intergration test workflow for notebook-controller Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…ow/kubeflow#6830) * Introduce intergration test workflow for notebook-controller Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Publish Docker image only when PR is merged Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Remove kind & manifest gh-action workflows Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Update tag in manifests to v1.6.0 This change is required as images with v1.5.0 do not exist in Dockerhub. Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves part of: kubeflow/notebooks#100
Changes: