Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission-webhook: Consolidate manifests #5719

Conversation

yanniszark
Copy link
Contributor

Umbrella-Issue: kubeflow/manifests#1769

PodDefaults Webhook

Current manifests structure

.
├── bootstrap
│   ├── base
│   └── overlays
│       └── application
└── webhook
    ├── base
    ├── overlays
    │   ├── application
    │   └── cert-manager
    └── v3

Explanation

  • bootstrap is a custom solution for creating a cert for the poddefaults webhook. I can't find the code for that solution in this repo. Instead of maintaining such code, we should rely on cert-manager.
  • webhook/v3: Combines application and cert-manager overlays. Since we now rely on plain kustomize, let's remove v3 and use the standard base and overlays structure of kustomize.
  • webhook/overlays/application: Adds an Application CR resource for the poddefaults webhook. We want to remove Application CRs, so this is a good opportunity to do so.
  • webhook/overlays/cert-manager: Add a cert-manager certificate for the poddefault webhook. This is the only useful overlay and the one that should remain.

Recommended end state

    ├── base
    ├── overlays
        └── cert-manager

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@yanniszark yanniszark force-pushed the feature-consolidate-manifests-poddefaults branch from 542c19e to bab9d10 Compare March 19, 2021 11:00
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@kimwnasptd
Copy link
Member

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit e046f90 into kubeflow:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants