Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook-server-rstudio-tidyverse dockerfile and CI/CD #5711

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

davidspek
Copy link
Contributor

@davidspek davidspek commented Mar 17, 2021

Part of #5575.

Initial images were built and pushed to test CI/CD:
public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/rstudio-tidyverse:master-87b7d015

@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@davidspek davidspek mentioned this pull request Mar 17, 2021
4 tasks
@davidspek davidspek changed the title Rstudio tidyverse Add notebook-server-rstudio-tidyverse dockerfile and CI/CD Mar 17, 2021
@davidspek
Copy link
Contributor Author

/test kubeflow-kubeflow-presubmit

@davidspek
Copy link
Contributor Author

/test kubeflow-kubeflow-presubmit

@google-cla
Copy link

google-cla bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 23, 2021
@google-cla
Copy link

google-cla bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@thesuperzapper
Copy link
Member

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@davidspek
Copy link
Contributor Author

@googlebot I consent

@google-cla
Copy link

google-cla bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@davidspek
Copy link
Contributor Author

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@thesuperzapper
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 23, 2021
@thesuperzapper
Copy link
Member

Looks good!
/approve
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 164fa2e into kubeflow:master Mar 23, 2021
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…kubeflow#5711)

* Add notebook-server-rstudio-tidyverse dockerfile and CI/CD

* cleanup rstudio tidyverse notebook image

Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…kubeflow#5711)

* Add notebook-server-rstudio-tidyverse dockerfile and CI/CD

* cleanup rstudio tidyverse notebook image

Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…kubeflow#5711)

* Add notebook-server-rstudio-tidyverse dockerfile and CI/CD

* cleanup rstudio tidyverse notebook image

Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
…kubeflow#5711)

* Add notebook-server-rstudio-tidyverse dockerfile and CI/CD

* cleanup rstudio tidyverse notebook image

Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
…kubeflow#5711)

* Add notebook-server-rstudio-tidyverse dockerfile and CI/CD

* cleanup rstudio tidyverse notebook image

Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants