-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook-server-rstudio-tidyverse dockerfile and CI/CD #5711
Add notebook-server-rstudio-tidyverse dockerfile and CI/CD #5711
Conversation
/test kubeflow-kubeflow-presubmit |
fc84c14
to
f5ac031
Compare
/test kubeflow-kubeflow-presubmit |
04ceb72
to
68919e6
Compare
68919e6
to
a8383b1
Compare
a8383b1
to
84d6d13
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
84d6d13
to
450ab00
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Looks good! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidSpek, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…kubeflow#5711) * Add notebook-server-rstudio-tidyverse dockerfile and CI/CD * cleanup rstudio tidyverse notebook image Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
…kubeflow#5711) * Add notebook-server-rstudio-tidyverse dockerfile and CI/CD * cleanup rstudio tidyverse notebook image Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
…kubeflow#5711) * Add notebook-server-rstudio-tidyverse dockerfile and CI/CD * cleanup rstudio tidyverse notebook image Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
…kubeflow#5711) * Add notebook-server-rstudio-tidyverse dockerfile and CI/CD * cleanup rstudio tidyverse notebook image Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
…kubeflow#5711) * Add notebook-server-rstudio-tidyverse dockerfile and CI/CD * cleanup rstudio tidyverse notebook image Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Part of #5575.
Initial images were built and pushed to test CI/CD:
public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/rstudio-tidyverse:master-87b7d015