Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook-server-jupyter-tensorflow-full dockerfiles and CI/CD #5632

Merged

Conversation

davidspek
Copy link
Contributor

@davidspek davidspek commented Feb 23, 2021

This PR adds the TensorFlow Jupyter opinionated images from #5582 that will serve as a starting point for (new) users and projects by adding an opinionated set of common tools. It uses #5627 and #5628 as the base images. These images also serve as important examples for people that would like to customize the TensorFlow base image for their distinct needs. More details about the downstream use of this image can be seen in the PR linked above.

Initial images were built and pushed to test CI/CD:
public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter-tensorflow-full:master-28af7716
public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter-tensorflow-cuda-full:master-28af7716

/cc @kubeflow/wg-notebooks-leads @thesuperzapper

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidSpek
To complete the pull request process, please assign thesuperzapper after the PR has been reviewed.
You can assign the PR to them by writing /assign @thesuperzapper in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@davidspek davidspek mentioned this pull request Feb 23, 2021
4 tasks
@davidspek davidspek force-pushed the opinionated-tensorflow-images branch 2 times, most recently from f619e37 to 369e237 Compare March 13, 2021 09:34
@davidspek davidspek changed the title (Notebooks rework): Add opinionated TensorFlow images with common tools Add notebook-server-tensorflow-full dockerfiles and CI/CD Mar 13, 2021
@davidspek davidspek force-pushed the opinionated-tensorflow-images branch from 369e237 to f7276f3 Compare March 13, 2021 10:53
@davidspek davidspek changed the title Add notebook-server-tensorflow-full dockerfiles and CI/CD Add notebook-server-jupyter-tensorflow-full dockerfiles and CI/CD Mar 20, 2021
@davidspek davidspek force-pushed the opinionated-tensorflow-images branch 3 times, most recently from c971952 to 17781dc Compare March 21, 2021 19:44
@davidspek
Copy link
Contributor Author

/test kubeflow-kubeflow-presubmit

@thesuperzapper thesuperzapper force-pushed the opinionated-tensorflow-images branch from 17781dc to 33d78bd Compare March 22, 2021 07:10
@thesuperzapper
Copy link
Member

Looks good!
/approve
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants