Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook-server-jupyter-pytorch-full dockerfiles and CI/CD #5631

Merged

Conversation

davidspek
Copy link
Contributor

@davidspek davidspek commented Feb 23, 2021

This PR adds the PyTorch Jupyter opinionated images from #5582 that will serve as a starting point for (new) users and projects by adding an opinionated set of common tools. It uses #5626 as the base image. These images also serve as important examples for people that would like to customize the PyTorch base image for their distinct needs. More details about the downstream use of this image can be seen in the PR linked above.

Initial images were built and pushed to test CI/CD:
public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter-pytorch-full:master-28af7716
public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter-pytorch-cuda-full:master-28af7716

/cc @kubeflow/wg-notebooks-leads @thesuperzapper

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidSpek
To complete the pull request process, please assign yanniszark after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@davidspek davidspek mentioned this pull request Feb 23, 2021
4 tasks
@davidspek davidspek force-pushed the opinionated-pytorch-images branch 2 times, most recently from d5479f3 to 7589c64 Compare March 12, 2021 16:01
@davidspek davidspek force-pushed the opinionated-pytorch-images branch from 7589c64 to d096cc4 Compare March 12, 2021 17:23
@davidspek davidspek changed the title (Notebooks rework): Add opinionated PyTorch images with common tools Add notebook-server-jupyter-pytorch-full dockerfiles and CI/CD Mar 12, 2021
@davidspek davidspek force-pushed the opinionated-pytorch-images branch 3 times, most recently from c398c0c to d6061b3 Compare March 21, 2021 16:48
@davidspek davidspek force-pushed the opinionated-pytorch-images branch from d6061b3 to d3b9a6c Compare March 21, 2021 17:35
@thesuperzapper
Copy link
Member

Looks good!
/approve
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants