Scripts for replicating Docker images using GCB to support private GKE and VPC service controls. #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E and VPC service controls.
* With private GKE we can't pull docker images from non-GCR registries (e.g. quoay)
* To support private GKE clusters we want to make it easy for users to
mirror Kubeflow images to their own registry
* We create a GCB workflow to retag Kubeflow images
* Using GCB is advantageous because it avoids pulling the networks over
the user's network.
* Update the script to update the Kubeflow components to use the images in the
user's registry.
* The kubeflow cluster isn't fully accessible yet.
looks like pipelines and some other components still have images that
need to be ported over.
Related to kubeflow#2086
jlewi
changed the title
|
/assign @IronPan |
IronPan
reviewed
Apr 23, 2019
| ks param set metacontroller image ${registry}/metacontroller:v0.3.0 | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
do you mind update pipeline's minio and mysql images
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/pipeline/pipeline.libsonnet#L9
nfs image can be ignored since it's not being used.
Thanks!
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Apr 29, 2019
… using GCB to #3111: Improve the scripts for mirroing images to support VPC Cherry pick of #3080 #3111 on v0.5-branch. #3080: Scripts for replicating Docker images using GCB to #3111: Improve the scripts for mirroing images to support VPC (#3124) * Scripts for replicating Docker images using GCB to support private GKE and VPC service controls. * With private GKE we can't pull docker images from non-GCR registries (e.g. quoay) * To support private GKE clusters we want to make it easy for users to mirror Kubeflow images to their own registry * We create a GCB workflow to retag Kubeflow images * Using GCB is advantageous because it avoids pulling the networks over the user's network. * Update the script to update the Kubeflow components to use the images in the user's registry. * The kubeflow cluster isn't fully accessible yet. looks like pipelines and some other components still have images that need to be ported over. Related to #2086 * Update the images. * Improve the scripts for mirroing images to support VPC service controls * Add more images to be mirror'd when using VPC service controls * When using VPC service controls not all GCR repos are accessible so some images hosted in GCR need to be mirror'd * Fix a bug in cloud-endpoints controller that prevents the image from being overwritten by parameters Related to #3106 Fixes to support VPC service controlls. * ESP sample web app should get the image from ksonnet parameters so it can be overwritten with a version from a mirror. * To support pipelines we need to mirror a bunch of images from gcr.io/ml-pipeline so they are accessible inside the service perimeter. Related to kubeflow/pipelines#1203 Related to kubeflow/pipelines#1204 * Fix test. * Try to fix error.
swiftdiaries
pushed a commit
to swiftdiaries/kubeflow
that referenced
this pull request
May 2, 2019
…E and VPC service controls. (kubeflow#3080) * Scripts for replicating Docker images using GCB to support private GKE and VPC service controls. * With private GKE we can't pull docker images from non-GCR registries (e.g. quoay) * To support private GKE clusters we want to make it easy for users to mirror Kubeflow images to their own registry * We create a GCB workflow to retag Kubeflow images * Using GCB is advantageous because it avoids pulling the networks over the user's network. * Update the script to update the Kubeflow components to use the images in the user's registry. * The kubeflow cluster isn't fully accessible yet. looks like pipelines and some other components still have images that need to be ported over. Related to kubeflow#2086 * Update the images.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…E and VPC service controls. (kubeflow#3080) * Scripts for replicating Docker images using GCB to support private GKE and VPC service controls. * With private GKE we can't pull docker images from non-GCR registries (e.g. quoay) * To support private GKE clusters we want to make it easy for users to mirror Kubeflow images to their own registry * We create a GCB workflow to retag Kubeflow images * Using GCB is advantageous because it avoids pulling the networks over the user's network. * Update the script to update the Kubeflow components to use the images in the user's registry. * The kubeflow cluster isn't fully accessible yet. looks like pipelines and some other components still have images that need to be ported over. Related to kubeflow#2086 * Update the images.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
…E and VPC service controls. (kubeflow#3080) * Scripts for replicating Docker images using GCB to support private GKE and VPC service controls. * With private GKE we can't pull docker images from non-GCR registries (e.g. quoay) * To support private GKE clusters we want to make it easy for users to mirror Kubeflow images to their own registry * We create a GCB workflow to retag Kubeflow images * Using GCB is advantageous because it avoids pulling the networks over the user's network. * Update the script to update the Kubeflow components to use the images in the user's registry. * The kubeflow cluster isn't fully accessible yet. looks like pipelines and some other components still have images that need to be ported over. Related to kubeflow#2086 * Update the images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With private GKE we can't pull docker images from non-GCR registries (e.g. quoay)
To support private GKE clusters we want to make it easy for users to
mirror Kubeflow images to their own registry
We create a GCB workflow to retag Kubeflow images
the user's network.
Update the script to update the Kubeflow components to use the images in the
user's registry.
The kubeflow cluster isn't fully accessible yet.
looks like pipelines and some other components still have images that
need to be ported over.
Related to #2086
This change is