Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seldon ksonnet integration #268

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Add seldon ksonnet integration #268

merged 2 commits into from
Feb 20, 2018

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Feb 19, 2018 •
edited by jlewi
Loading

Fixes #159

  • Called seldon rather than seldon-core not to overlap with existing core prototype
  • Raw JSON is keep in separate folder and then ksonnet Mixins used for construction.

Known issues

  • RBAC setting is clusterwide admin at present. Not done work to define a more limited defn.
  • Not sure if there is a style guide for jsonnet files but I'm using emacs and didn't find a nice mode to format them.

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Feb 20, 2018

LGTM.

@cliveseldon Is there anyone else that should review this before I merge it?

Should we open up an issue to add E2E tests?

@ukclivecox
Copy link
Contributor Author

ukclivecox commented Feb 20, 2018 •
edited
Loading

  • People at Seldon have reviewed, not sure who outside seldon.
  • Yes e2e test issue would be good. Do you have any docs or existing examples? I assume we would need to set up the test infra locally. I couldn't find docs to prow?

Next steps after this is merged is to change the example-seldon docs to reference kubeflow setup and this. Plus do the e2e tests.

@jlewi
Copy link
Contributor

jlewi commented Feb 20, 2018

Our current tests are here
https://github.com/kubeflow/kubeflow/tree/master/testing

Our E2E tests are written as Argo workflows where each step generally runs a python script.

So the first step would be to deploy Seldon core and verify that all the containers etc... start.
You could then try deploying an actual model and sending predictions to it.

You could either create a new workflow or add it to our existing E2E workflow.

@jlewi jlewi merged commit f38d342 into kubeflow:master Feb 20, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
@johnugeorge @k8s-ci-robot
Adding manifests for kfserving (kubeflow#268)
8c5b9ce 
* Adding manifests for kfserving

* Add tests

* Addressing review comments

* Adding tests

* Adding manifests for kfserving

* Add tests

* Addressing review comments

* Adding tests

* added registry var

* rebase from upstream/master, add unit test
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
@xfate123
Update org.yaml (kubeflow#268)
512d8ac 
Wish to contribute more to kubeflow community in the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukclivecox @jlewi @k8s-ci-robot