Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'kfctl.sh delete platform' doesn't delete platform correctly. #1360

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Aug 14, 2018

Platform deletion was improperly being triggered on what= k8s and not what=platform; this was a bug.
/assign @jlewi


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Aug 14, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor

jlewi commented Aug 14, 2018

/test all

@k8s-ci-robot k8s-ci-robot merged commit bdb9775 into kubeflow:master Aug 14, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants