Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensorboard Controller is not handling generateVirtualService errors #7040

Closed
japan4415 opened this issue Mar 14, 2023 · 2 comments · May be fixed by #7067
Closed

Tensorboard Controller is not handling generateVirtualService errors #7040

japan4415 opened this issue Mar 14, 2023 · 2 comments · May be fixed by #7067
Labels
kind/bug

Comments

@japan4415
Copy link

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

I realize this bug when I apply Tensorboard Controller without ISTIO_GATEWAY config.

What did you expect to happen:
If you apply this controller without ISTIO_GATEWAY config, virtualService will be nil and crush with nil pointer at L114.
So we should handle errors at L113.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Can I make PR for fix this?

Environment:

  • Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard):
  • kfctl version: (use kfctl version):
  • Kubernetes platform: (e.g. minikube)
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@japan4415 japan4415 mentioned this issue Mar 25, 2023
Open
@juliusvonkohout
Copy link
Member

/close
as decided by @andreyvelich @tarilabs in the migration document

@google-oss-prow Google OSS Prow
Copy link

@juliusvonkohout: Closing this issue.

In response to this:

/close
as decided by @andreyvelich @tarilabs in the migration document

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add error handling to tensorboard controller japan4415/kubeflow
2 participants
@japan4415 @juliusvonkohout