-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Tensorboard with Object Store #6493
Comments
This is currently not supported, but a great feature to implement. We've solved this problem in Notebooks by using PodDefaults for attaching credentials, but we might need to have some more logic for TensorBoard. @N-Kingsley have you managed to configure TensorBoard locally to access MinIO? |
No, how should I solve this problem? |
I solved this problem by add credential env for tensorboard pod. Is it a plan to support in v1.6? |
I think it would be a very useful feature to support s3. |
AFAIK TensorBoard should be able to work with credentials that are set by ENV Variables https://github.com/tensorflow/tensorboard/blob/master/tensorboard/summary/writer/event_file_writer_s3_test.py#L35-L36 Ideally we should extend our TensorBoard CR to make it possible to assign PodDefaults to the underlying Pod that will be created. This way we can have the same approach for injecting AWS credentials to both Notebook and TensorBoard servers. This will require some changes to both the web app and the underlying CR though. Any takers? |
@wyljpn just saw your comment in the other issue, let's use this one for this specific feature #3578 (comment) First of all nice work! As mentioned above instead of expecting users to edit ENV vars directly let's instead use PodDefaults, so that we can reuse this part for Notebooks as well. We can also document a PodDefault that sets the ENV Vars accordingly. The changes I have in mind are:
We can break this down to small PRs for each one as well |
As a side-note: I went down the route as described in #3578 and compiled a custom controller. It works, however logs in subfolders are not being listed if the tensorboard points to the parent directory (which is annoying as it requires one board per run). It is different if one uses a more recent version of the |
Could you tell me how to solve this problem? |
Just create a secret and poddefault before create tensorboard for quick workaround. The name
|
@kimwnasptd this is a great idea! I can implement this, if no one is working on it? |
Is this issue fixed @kimwnasptd @surajkota ? |
@AlexandreBrown yes and it is available in 1.7-rc1, you can find the instructions on the description of this PR - #6924 |
This has been fixed in #6924 |
How to write a right Object Storage Link?
For example, how to set the access key and secret key in the link when using the Minio.
The text was updated successfully, but these errors were encountered: