Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s 1.22 and Notebooks WG #6353

Closed
kimwnasptd opened this issue Feb 11, 2022 · 14 comments · Fixed by #6491
Closed

K8s 1.22 and Notebooks WG #6353

kimwnasptd opened this issue Feb 11, 2022 · 14 comments · Fixed by #6491
Labels

Comments

@kimwnasptd
Copy link
Member

kimwnasptd commented Feb 11, 2022

While for KF 1.5 release we are targeting K8s 1.20 and 1.21, I'm starting this tracking issue on the work items required for supporting K8s 1.22. Related issue #6098

This is an overview of the items I have in mind:

  1. Use of the newer v1 for SubjectAccessReviews https://kubernetes.io/docs/reference/using-api/deprecation-guide/#subjectaccessreview-resources-v122
  2. Update the RBAC resources of at least the crud-web- apps https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122
  3. Migrating to v1 for CustomResourceDefinitions https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122
  4. The failure policy for webhooks has changed from Ignore to Fail https://kubernetes.io/docs/reference/using-api/deprecation-guide/#webhook-resources-v122. This is a good thing, but we need to double check edge cases scenarios with use of our PodDefaults

These are the work items I have in mind. The first two are easy to implement. The only ones that might need more care are the CRDs and testing the webhook.

Component Status Sub-Issue/PR
Notebook Controller #6366
Profile Controller #6491
TensorBoard Controller #6406
Admission Webhook (PodDefaults) #6428
Crud Web Apps #6427

cc @kubeflow/wg-notebooks-leads

@samuelvl
Copy link
Contributor

Hi @kimwnasptd At ODH we want to deploy Notebook Controller on Openshift 4.9 (Kubernetes 1.22) so we would like to contribute to support K8S 1.22.

Is there any PR in progress? If not, we can start with any of the outstanding items.

@kimwnasptd
Copy link
Member Author

Great to hear @samuelvl!

I'll open a distinct issue for the Notebook Controller to track the required effort there.

@mvoitko
Copy link

mvoitko commented Feb 22, 2022

Do you need any help?

@jbottum
Copy link
Contributor

jbottum commented Feb 26, 2022

/area jupyter
/kind feature
/priority p1

@kimwnasptd
Copy link
Member Author

Hi @mvoitko, first of all hope you are safe.

Yes, we have some more work items for this effort. I'll create some more subissues for the different components.

You can take a look at the overview in the first comment. Do you have any preference on where you could help? Golang controllers, Python backends, YAML manifests?

@lukeogg
Copy link

lukeogg commented Mar 11, 2022

Hi there, I have some availability to help with 1.22 compatibility. I believe that some of our other team members will reach out as well.

@Talador12
Copy link

I am also available to help on 1.22 compatibility. The sooner we upgrade to 1.22 syntax, the better!

@alembiewski
Copy link
Member

Opened a PR for updating Tensorboard CRD to v1: #6406

@spots107
Copy link

Getting 1.22 support for Kubeflow is very important, but are there any known issues with 1.23 that should be called out for addressing as well? The reason for asking is that 1.22 goes end of active support at the end of Aug and EOL at the end of Oct based on https://endoflife.date/kubernetes.

@kimwnasptd
Copy link
Member Author

Awesome to see so much help on this one! I've also created two more issues to handle PodDefaults #6428 and the crud web apps (backend) #6427. The later should be an easier task.

I'll be working also in parallel on using KinD within the Argo Workflows we use for E2E testing, so that we can also do some basic tests on K8s 1.22. EKS does not yes support K8s 1.22 so we'll have to compromise.

@chlun1
Copy link

chlun1 commented Jun 8, 2022

How likely is it that support for 1.22 will be in the next release of Kubeflow and within the planned schedule?

1.21 is reaching end of life at the end of June and Kubeflow 1.6 is planned to be released on 20th July so there's a gap of about of month when you can only use Kubeflow on an unsupported Kubernetes version. Is there any possibility of a patch to make Kubeflow install-able on Kubernetes 1.22 to fill the gap?

@jbottum
Copy link
Contributor

jbottum commented Jun 8, 2022

@chlun1 The community has been committed to delivering support for 1.22 in Kubeflow 1.6 and I will let @annajung and @kimwnasptd comment as well. Kubeflow 1.6 target release date is in August. The Kubeflow Working Groups may need some help. Are there folks on your team that might be able to contribute, perhaps in testing ? Which cloud environment are you running in or Kubeflow distribution do you plan to use ?

@chlun1
Copy link

chlun1 commented Jun 8, 2022

@jbottum We are running Kubeflow on Azure. We can possibly help in testing on Azure.

@davidxia
Copy link

davidxia commented Jun 8, 2022

@jbottum I'm using Kubeflow pipelines and UI on GKE 1.21 right now and can also help test.

GCP will automatically upgrade my GKE clusters from 1.21 to 1.22 at the end of this year according to their release schedule. So the target August release for Kubeflow 1.6 gives my team a good amount of time to upgrade both our clusters and Kubeflow.

We don't want to be in a situation where our clusters are automatically upgraded to 1.22 and we have no compatible Kubeflow release or time to upgrade. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants