Skip to content

Clean up dead code in kubeflow/kubeflow? #5419

Closed
@jlewi

Description

Follow on to kubeflow/community#454?

The question posed in that issue is:

What's the kubeflow/kubeflow positioning? Should we deprecate it once notebook and control plane components move out of it?

With the exception of notebooks and one or two other packages (e.g. PodDefaults) that should probably move into WG owned repositories (#5418) it looks like most of the code in kubeflow/kubeflow is dead code. We should probably delete it and aim to whiddle down the repo to just a readme.

Looking at the top level directories

  • bootstrap - this can be deleted; all relevant code should now be in kubeflow/kfctl
  • build - This looks like some utilities for managing license files in code
    • We should probably keep it but might want to move it
    • kubeflow/testing is generally where we've been gathering shared engprod resources
  • components - This directory should be whiddled down to nothing
    • Sub directories should either be moved into WG owned repositories or be deleted if they are no longer being developed/maintained
  • docs/gke - This should probably move to a GCP directory (gcp-blueprints?) or be deleted if no longer used
  • hack - should probably move to kubeflow/testing for shared engprod
  • metric-collector - I don't believe this is being maintained so we can probably just delete it
    • If a WG wants to claim it they should move it to one of their repos
  • py/kubeflow - I don't think this is being used anymore so it can probably be deleted
    • It looks like its just engprod scripts so if its being used it should move to kubeflow/testing
  • releasing - dead code; just delete
  • scripts
    • This looks like outdated scripts that have been superseded by other solutions
    • WGs should probably claim anything if they still need it.
    • I would suggest just deleting the directory to shakeout who might still be depending on it
  • testing
    • Similar to scripts
    • Any generic testing code still in use should live in kubeflow/testing
  • tf-controller-examples
    • Delete; looks very stale
    • Any operator specific examples should move into training operator repos
  • tools/gcb - delete

Activity

Jeffwan

Jeffwan commented on Nov 21, 2020

@Jeffwan
Member

/assign @Jeffwan

Jeffwan

Jeffwan commented on Nov 21, 2020

@Jeffwan
Member

docs_dev seems need some updates, it should be renamed to docs?

code snippet in docs/gke seems still helpful. I can leave to @Bobgy to remove to right place.

Jeffwan

Jeffwan commented on Nov 21, 2020

@Jeffwan
Member

I will move some useful scripts like auto cherry-pick and update changelog in hack and scripts to kubeflow/testing

Bobgy

Bobgy commented on Nov 23, 2020

@Bobgy
Contributor

I'll take a look about gcp stuff, thanks a lot for taking care of others @Jeffwan !

jbottum

jbottum commented on Jan 8, 2021

@jbottum
Contributor

/area testing
/priority p1
/platform gcp

davidspek

davidspek commented on Mar 20, 2021

@davidspek
Contributor

Once WG-Notebooks has it's own repository I think this issue will be solved.

12 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Clean up dead code in kubeflow/kubeflow? · Issue #5419 · kubeflow/kubeflow