Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: refactor existing_arrikto test to use pyfunc #4189

Closed
yanniszark opened this issue Sep 26, 2019 · 4 comments
Closed

e2e: refactor existing_arrikto test to use pyfunc #4189

yanniszark opened this issue Sep 26, 2019 · 4 comments
Labels
area/kfctl kind/feature lifecycle/stale priority/p1

Comments

@yanniszark
Copy link
Contributor

yanniszark commented Sep 26, 2019 •
edited
Loading

/kind feature

Why you need this feature:
All E2E tests are refactored to use pyfunc and move away from the deprecated ksonnet tools.

Describe the solution you'd like:
The existing_arrikto E2E tests should:

  • Use a pyfunc in prow.yaml to define their workflows.
  • Split create, delete cluster into separate workflow steps.

Followup from: #4154
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@yanniszark
Copy link
Contributor Author

/priority p1

@yanniszark yanniszark mentioned this issue Sep 26, 2019
Merged
@jlewi
Copy link
Contributor

jlewi commented Nov 5, 2019

I believe the current plan is to combine kfctl_existing_arrikto with kfctl_istio_dex.yaml

This means we should have a single E2E test which is being tracked in #3496

@jlewi jlewi mentioned this issue Nov 6, 2019
Closed
@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Feb 3, 2020
@stale stale bot closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kfctl kind/feature lifecycle/stale priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlewi @yanniszark @jbottum @k8s-ci-robot