Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating releases we should pin the version of source.tar.gz used in the deploy.sh #1239

Closed
jlewi opened this issue Jul 19, 2018 · 2 comments
Closed

When creating releases we should pin the version of source.tar.gz used in the deploy.sh #1239

jlewi opened this issue Jul 19, 2018 · 2 comments
Labels
area/0.3.0 priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 19, 2018

If you pull deploy.sh from a release branch, by default you should get the source.tar.gz associated with that branch. But that's not what currently happens because the default version is master.

As part of a release we should update deploy.sh so we get the source repo at the same version as deploy.sh

kubeflow/website#96 - Using our website we can now create redirects to github URLs.

So we could create links like

https://kubeflow.org/version/0.2.2/source.tar.gz

This way we can just redirect that link to different RCs without having to update deploy.sh.
This was referenced Jul 22, 2018
Closed
Closed
Closed
@jlewi
Copy link
Contributor Author

jlewi commented Aug 20, 2018

I fixed this on the 0.2.2 branch.

At master we should upload download.sh and update the release instructions.

@jlewi
Copy link
Contributor Author

jlewi commented Sep 3, 2018

With the latest config scripts we now use download.sh
https://github.com/kubeflow/kubeflow/blob/master/scripts/download.sh

All the files downloaded will be at a single commit.

We still have the problem that download.sh might be pointing by default at a different commit. We can potentially fix that by redirecting to download.sh from
https://kubeflow.org
so that we can potentially reference a different version of the script.

At any rate closing this issue since we don't use deploy.sh

@jlewi jlewi closed this as completed Sep 3, 2018
@snyk-bot snyk-bot mentioned this issue Jul 17, 2020
Open
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
@andreyvelich
Katib manifests for Kubeflow 1.1 (kubeflow#1239)
6e0925a 
* Change manifest for Kubeflow 1.1

* Generate tests

* Change image tag from 5df1bd2 to 917164a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/0.3.0 priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi