Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of converting Store Sales Forecast Kaggle notebook to a Kubeflow pipeline #994

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Example of converting Store Sales Forecast Kaggle notebook to a Kubeflow pipeline #994

merged 4 commits into from
Oct 12, 2022

Conversation

NeoKish
Copy link
Contributor

@NeoKish NeoKish commented Sep 6, 2022

/assign @kimwnasptd
/assign @js-ts
/assign @jinchihe

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-oss-prow google-oss-prow bot requested review from jinchihe and js-ts September 6, 2022 14:11
@NeoKish NeoKish changed the title Example of converting Store-Sales Kaggle notebook to a Kubeflow pipeline Example of converting Store-Sales Forecast Kaggle notebook to a Kubeflow pipeline Sep 6, 2022
@NeoKish NeoKish changed the title Example of converting Store-Sales Forecast Kaggle notebook to a Kubeflow pipeline Example of converting Store Sales Forecast Kaggle notebook to a Kubeflow pipeline Sep 6, 2022
@jbottum
Copy link

jbottum commented Sep 6, 2022

@NeoKish thanks for this documentation and tutorial update. A few questions. Does this run on KF 1.6 ? This tutorial uses Kale. Does Kale require Rok ?

@NeoKish
Copy link
Contributor Author

NeoKish commented Sep 6, 2022

@jbottum, thanks for the comment. So I am using Arrikto's KFaaS. The Kubeflow version is 1.4 based on the latest release. Yes Kale does have dependency on Rok.

@kimwnasptd
Copy link
Member

Took a look at the code of the example

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 12, 2022
@akgraner
Copy link

Thank you for your contribution!

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akgraner, NeoKish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a79f117 into kubeflow:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchihe jinchihe Awaiting requested review from jinchihe

@js-ts js-ts Awaiting requested review from js-ts

Assignees

@kimwnasptd kimwnasptd

@jinchihe jinchihe

@js-ts js-ts

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NeoKish @jbottum @kimwnasptd @akgraner @jinchihe @js-ts