-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'simple pipeline' notebook update to reflect SDK changes and KF notebook image changes #705
Conversation
…ook images changes
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Alexey, would you have time to review this? It updates from build_python_component to func_to_container_op, plus also changes the command to install/update the kfp sdk. (+ a few other small cosmetic fixes). @Ark-kun |
@@ -213,7 +170,7 @@ | |||
"source": [ | |||
"#### Create an Experiment in the Pipeline System\n", | |||
"\n", | |||
"Pipeline system requires an \"Experiment\" to group pipeline runs. You can create a new experiment, or call client.list_experiments() to get existing ones." | |||
"Kubeflow Pipelines lets you group pipeline runs by *Experiments*. You can create a new experiment, or call `client.list_experiments()` to see existing ones." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace create_experiment+compile+run_pipeline with client.create_run_from_pipeline_func
, like in the kubeflow/pipelines
' samples.
What do you think of this version? I added the 'create_run_from_pipeline_func' example and showed it first, but kept the other variant as an alternative, as people might also find it useful to know how to generate the compiled pipeline artifact. @Ark-kun |
just a bump on this :) @Ark-kun |
Note the change from Python 3.7.x to 3.6.x. Not sure this was intentional. Please verify. |
/lgtm |
/approve hi Chris, I believe the key thing is that it's specifying python 3 (vs py27), and will grab any py3 kernel that is available (which will work fine)... so I don't believe that change matters. LMK if you know differently, though. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amygdala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is