Update pytorch_mnist example to use v1beta1 #445
Conversation
|
/retest |
|
/assign @kunmingg |
|
Is there any reason we need to keep the old v1alpha2 files around? If not, let's remove them. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gabrielwen and @cwbeitel)
pytorch_mnist/training/ddp/mnist/cpu/v1beta1/job_mnist_DDP_CPU.yaml, line 0 at r1 (raw file):
This YAML shouldn't be empty.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
gabrielwen
force-pushed
the
update-pytorch
branch
from
8984f41 to
d774e42
Compare
|
CLAs look good, thanks! |
removed :) |
|
/test kubeflow-examples-presubmit |
There was a problem hiding this comment.
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @dsdinter and @cwbeitel)
pytorch_mnist/training/ddp/mnist/cpu/v1beta1/job_mnist_DDP_CPU.yaml, line at r1 (raw file):
Previously, dsdinter (David Sabater Dinter) wrote…
This YAML shouldn't be empty.
Done.
|
/test kubeflow-examples-presubmit |
|
/retest |
1 similar comment
|
/retest |
|
/test kubeflow-examples-presubmit |
1 similar comment
|
/test kubeflow-examples-presubmit |
|
/test kubeflow-examples-presubmit |
|
This PR is ready. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsdinter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add job_mnist_DDP_CPU for v1beta1 * Add job_mnist_DDP_GPU for v1beta1 * Update 02_distributed_training.md to use v1beta1 * Remove pytorch v1alpha2 config * Add missing CPU training config
Currently if we deploy kubeflow from HEAD, tf operator is default at v1beta1. Updating example here to match with it.
This change is